linux-mips
[Top] [All Lists]

Re: [PATCH 2/9] MIPS: Netlogic: Remove unused EIMR/EIRR functions

To: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 2/9] MIPS: Netlogic: Remove unused EIMR/EIRR functions
From: "Jayachandran C." <jchandra@broadcom.com>
Date: Mon, 25 Mar 2013 12:48:29 +0530
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <514E038D.50108@cogentembedded.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <cover.1364062916.git.jchandra@broadcom.com> <9e189bdc53ac2650d22d18f037df89dd2e412be9.1364062916.git.jchandra@broadcom.com> <514E038D.50108@cogentembedded.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Mar 23, 2013 at 10:33:33PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 03/23/2013 09:27 PM, Jayachandran C wrote:
> 
> >Remove the definitions of {read,write}_c0_{eirr,eimr}. These functions
> >are now unused after the PIC and IRQ code has been updated to use
> >optimized EIMR/EIRR functions which work on both 32-bit and 64-bit.
> >
> >Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> >---
> >  arch/mips/include/asm/netlogic/mips-extns.h |    7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> >diff --git a/arch/mips/include/asm/netlogic/mips-extns.h 
> >b/arch/mips/include/asm/netlogic/mips-extns.h
> >index 69d18a0..f299d31 100644
> >--- a/arch/mips/include/asm/netlogic/mips-extns.h
> >+++ b/arch/mips/include/asm/netlogic/mips-extns.h
> [...]
> >@@ -140,7 +136,6 @@ static inline uint64_t read_c0_eirr_and_eimr(void)
> >             ".set   pop"
> >             : "=r" (val));
> >  #endif
> >-
> 
>    Unrelated whitespace change.
> 
> >     return val;
> >  }

While updating that function, I had removed an empty line which was not
really needed. Not sure if it is worth adding a line in commit message for
that.

JC.


<Prev in Thread] Current Thread [Next in Thread>