linux-mips
[Top] [All Lists]

[PATCH] Revert "MIPS: BCM63XX: Call board_register_device from device_in

To: linux-mips@linux-mips.org
Subject: [PATCH] Revert "MIPS: BCM63XX: Call board_register_device from device_initcall()"
From: Jonas Gorski <jogo@openwrt.org>
Date: Tue, 19 Mar 2013 15:20:19 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Florian Fainelli <florian@openwrt.org>, Kevin Cernekee <cernekee@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Sender: linux-mips-bounce@linux-mips.org
This commit causes a race between PCI scan and SSB fallback SPROM handler
registration, causing the wifi to not work on slower systems. The only
subsystem touched from board_register_devices is platform device
registration, which is safe as an arch init call.

This reverts commit d64ed7ada2f689d2c62af1892ca55e47d3653e36.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
---

This patch is in OpenWrt since ages, and we never encountered any issues
from this revert.

 arch/mips/bcm63xx/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/bcm63xx/setup.c b/arch/mips/bcm63xx/setup.c
index 314231b..35e18e9 100644
--- a/arch/mips/bcm63xx/setup.c
+++ b/arch/mips/bcm63xx/setup.c
@@ -157,4 +157,4 @@ int __init bcm63xx_register_devices(void)
        return board_register_devices();
 }
 
-device_initcall(bcm63xx_register_devices);
+arch_initcall(bcm63xx_register_devices);
-- 
1.7.10.4


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] Revert "MIPS: BCM63XX: Call board_register_device from device_initcall()", Jonas Gorski <=