linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: Get rid of CONFIG_CPU_HAS_LLSC again

To: Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH v2] MIPS: Get rid of CONFIG_CPU_HAS_LLSC again
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 12 Mar 2013 17:09:12 +0100
Cc: Jonas Gorski <jogo@openwrt.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Chris Dearman <chris.dearman@imgtec.com>
In-reply-to: <1362486020.16460.73.camel@x61.thuisdomein>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362477800.16460.69.camel@x61.thuisdomein> <CAOiHx=nzNVatEp0nyfZKU2p35+1kjrw6VsvZTP+QPJykWF3JAg@mail.gmail.com> <1362486020.16460.73.camel@x61.thuisdomein>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 05, 2013 at 01:20:20PM +0100, Paul Bolle wrote:

> Commit f7ade3c168e4f437c11f57be012992bbb0e3075c ("MIPS: Get rid of
> CONFIG_CPU_HAS_LLSC") did what it promised to do. But since then that
> macro and its Kconfig symbol popped up again. Get rid of those again.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) This version fixes an embarrassing dangling "#endif" spotted by
> Jonas. Thanks for that! Still untested.

Thanks, I've applied your v2 patch.

It's good that your cleanup doesn't change the behaviour of the existing
code - however the current behaviour doesn't seem to be the intended
behaviour so I'm going to commit a separate patch to define cpu_has_llsc
to 1.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>