linux-mips
[Top] [All Lists]

Re: [PATCH] mips: lib/bitops.c: fix wrong return type

To: Zhi-zhou Zhang <zhizhou.zh@gmail.com>
Subject: Re: [PATCH] mips: lib/bitops.c: fix wrong return type
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 12 Mar 2013 14:54:41 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1363093253-17595-1-git-send-email-zhizhou.zh@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <n> <1363093253-17595-1-git-send-email-zhizhou.zh@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 12, 2013 at 09:00:53PM +0800, Zhi-zhou Zhang wrote:

> Here should return 64-bit types rather than 32-bit types. Or we
> may get wrong return value if high 32-bit isn't equal to zero.

David Daney's patch which I've applied not two hours before you posted
this patch solves the same issue though a different way.  So I'm just
going to drop this patch.

Thanks anyway!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>