linux-mips
[Top] [All Lists]

Re: [PATCH v2] pci: convert to devm_ioremap_resource()

To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v2] pci: convert to devm_ioremap_resource()
From: Silviu Popescu <silviupopescu1990@gmail.com>
Date: Tue, 12 Mar 2013 13:31:06 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, juhosg@openwrt.org, blogic@openwrt.org, kaloz@openwrt.org, xsecute@googlemail.com, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=XfcYipj6tHYKllWf8R0wqG0zc4LK17rZShT5ZBBA1ww=; b=Lgp6NGr1rvcW7bfJ7uYE67YBTGwtR6cupV2QMPZUKWZyGsVX3QUPhPEDzygEYjxGZ7 bcmySqn+lmvKZiLq7aUi31HKlWpKMRZq0uGSLy9VKk/QCXbCwPvBC5MrTFARcytCzmGp 4GriH19WFJnsnnP2tCb1IdieIUe63gNXQceStQiZMk5AdB95hDOHMovVHN36OksBlq2w 1Rwm2AE1Onx/JTRog/CW3W69MfW/2PRuhWmXaP79tBnJz9guBfUe2W9WTfXIvQNGrStu iar3unDWg590HXl1ghs8IAsZlKyVPbJJsK9Ye27Bp3FJh1CuXmDiFtpcKFmnj8ldTajQ pBuw==
In-reply-to: <513F0EC8.60709@cogentembedded.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1363073281-9939-1-git-send-email-silviupopescu1990@gmail.com> <513F0EC8.60709@cogentembedded.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Mar 12, 2013 at 1:17 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
> On 12-03-2013 11:28, Silviu-Mihai Popescu wrote:
>
>> Convert all uses of devm_request_and_ioremap() to the newly introduced
>> devm_ioremap_resource() which provides more consistent error handling.
>
>
>> devm_ioremap_resource() provides its own error messages so all explicit
>> error messages can be removed from the failure code paths.
>
>
>    There were no error messages as far as I could see, so this passage seems
> superfluous...

Sorry for that, I sent a refreshed version of the patch.

Thanks,
Silviu

<Prev in Thread] Current Thread [Next in Thread>