linux-mips
[Top] [All Lists]

Re: [PATCH] pci: use newly introduced devm_ioremap_resource()

To: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Subject: Re: [PATCH] pci: use newly introduced devm_ioremap_resource()
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 11 Mar 2013 22:07:53 +0300
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, juhosg@openwrt.org, blogic@openwrt.org, kaloz@openwrt.org, linux-kernel@vger.kernel.org
In-reply-to: <1363015477-29685-1-git-send-email-silviupopescu1990@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Cogent Embedded
References: <1363015477-29685-1-git-send-email-silviupopescu1990@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130215 Thunderbird/17.0.3
Hello.

On 03/11/2013 06:24 PM, Silviu-Mihai Popescu wrote:

Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
  arch/mips/pci/pci-ar71xx.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

   I think the idea was to combine changes to the 2 files in one patch.
Then the subject will truly reflect what it's doing...

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>