linux-mips
[Top] [All Lists]

Re: [PATCH] pci: convert to devm_ioremap_resource()

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH] pci: convert to devm_ioremap_resource()
From: Gabor Juhos <juhosg@openwrt.org>
Date: Mon, 11 Mar 2013 11:14:01 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <513DAAAA.1050003@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362987753-6607-1-git-send-email-silviupopescu1990@gmail.com> <513DAB22.2060309@openwrt.org> <513DAAAA.1050003@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
2013.03.11. 10:58 keltezéssel, John Crispin írta:
> On 11/03/13 11:00, Gabor Juhos wrote:
>> 2013.03.11. 8:42 keltezéssel, Silviu-Mihai Popescu írta:
>>> Convert all uses of devm_request_and_ioremap() to the newly introduced
>>> devm_ioremap_resource() which provides more consistent error handling.
>>>
>>> devm_ioremap_resource() provides its own error messages so all explicit
>>> error messages can be removed from the failure code paths.
>>>
>>> Signed-off-by: Silviu-Mihai Popescu<silviupopescu1990@gmail.com>
>>> ---
>>>   arch/mips/pci/pci-ar724x.c |   18 +++++++++---------
>>>   1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> Acked-by: Gabor Juhos<juhosg@openwrt.org>
>>
>> Just a minor note, arch/mips/pci/pci-ar71xx.c should be fixed as well 
>> probably.
>>
>>
> 
> 
> Hi,
> 
> is this patch supposed to go upstream via linux-mips.org ?

Yes, IMHO.

-Gabor

<Prev in Thread] Current Thread [Next in Thread>