linux-mips
[Top] [All Lists]

Re: [PATCH] Staging: Netlogic XLR/XLS GMAC driver

To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] Staging: Netlogic XLR/XLS GMAC driver
From: "Ganesan Ramalignam" <ganesanr@broadcom.com>
Date: Tue, 5 Mar 2013 21:44:13 +0530
Cc: "Ralf Baechle" <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <20130305141929.GA4434@kroah.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362464958-8722-1-git-send-email-ganesanr@broadcom.com> <20130305065851.GA30028@kroah.com> <20130305141353.GB29102@ganesanr.netlogicmircro.com> <20130305141929.GA4434@kroah.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Tue, Mar 05, 2013 at 10:19:29PM +0800, Greg Kroah-Hartman wrote:
> On Tue, Mar 05, 2013 at 07:43:54PM +0530, Ganesan Ramalignam wrote:
> > On Tue, Mar 05, 2013 at 02:58:51PM +0800, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 05, 2013 at 11:59:18AM +0530, ganesanr@broadcom.com wrote:
> > > >  This patch has to be merged via staging tree.
> > > > 
> > > >  This driver has been submitted to netdev tree and reviewed, the 
> > > > comments 
> > > >  are list in TODO list, will be addressed in next cycle of submission, 
> > > > till
> > > >  that time I wanted this driver to be in staging tree.
> > > > 
> > > >  This driver shall be sent to netdev@vger.kernel.org and David Miller 
> > > > <davem@davemloft.net>
> > > >  for further review.
> > > 
> > > When is that going to happen?
> > > 
> > 
> > In two months.
> 
> Why then?  What is so magic about 2 months?  In two months, this driver
> is not going to be in a released version of the kernel yet.
> 

Hi Greg,

Sorry, I think my previous mail did not give more detail, let me
clarify now.

The plan is to make the changes as per the comments received so far and
submit it again for review. There may be more changes and development when
this driver reviewed again, this process might take time of 2 months or even
more. Also this driver is useful to people with XLR/XLS board right now,
so I would like to move this driver to staging, once it reaches the standard
will be moved to netdev tree.

Please let me know if anything wrong in this approach.

> > > > --- /dev/null
> > > > +++ b/drivers/staging/netlogic/Kconfig
> > > > @@ -0,0 +1,7 @@
> > > > +config NETLOGIC_XLR_NET
> > > > +       tristate "Netlogic XLR/XLS network device"
> > > > +       depends on CPU_XLR
> > > 
> > > Why will this not build on any other platform?  It should, right?
> > > 
> > >
> > 
> > This driver is for XLR processor ethernet, which is depend on FMN
> > for any communication between packet processing agents, so this driver
> > depend on XLR platform.
> 
> What is "FMN"?
> 

This driver is for the network accelerator integrated into the
Netlogic XLR/XLS processor family. It uses the Fast Message
Network(FMN) present only on the Netlogic XLR/XLS SoCs, FMN is 
used for sending descriptors between CPUs and high speed interfaces
on XLR/XLS SoC (the code for this is in arch/mips/netlogic/xlr/fmn*),
so I do not see it being used on other platforms.

> thanks,
> 
> greg k-h
> 


<Prev in Thread] Current Thread [Next in Thread>