linux-mips
[Top] [All Lists]

Re: [PATCH] Staging: Netlogic XLR/XLS GMAC driver

To: ganesanr@broadcom.com
Subject: Re: [PATCH] Staging: Netlogic XLR/XLS GMAC driver
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Tue, 5 Mar 2013 14:58:51 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=tx7Hz+2CXaL0iH79EKHYWfDbFKgUuqCaq8ZZZ9k5tr0=; b=Sjm4Jj6MNuhwc5azxoi3DN+3FIcqFyrFBqIjWzsE51KKAL/iHGNL/fiWGXAxTN2bkc mxcau2utZTbMFFuA4XSXOCRdgTwV7/p6dA9+grAkB/jP66mMwP9WQyg1p1nkeHsBIUhL dK0fGDMZ824c8q5OfYDUw4dK5xOZm6816pcuY=
In-reply-to: <1362464958-8722-1-git-send-email-ganesanr@broadcom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362464958-8722-1-git-send-email-ganesanr@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 05, 2013 at 11:59:18AM +0530, ganesanr@broadcom.com wrote:
>  This patch has to be merged via staging tree.
> 
>  This driver has been submitted to netdev tree and reviewed, the comments 
>  are list in TODO list, will be addressed in next cycle of submission, till
>  that time I wanted this driver to be in staging tree.
> 
>  This driver shall be sent to netdev@vger.kernel.org and David Miller 
> <davem@davemloft.net>
>  for further review.

When is that going to happen?

> --- /dev/null
> +++ b/drivers/staging/netlogic/Kconfig
> @@ -0,0 +1,7 @@
> +config NETLOGIC_XLR_NET
> +     tristate "Netlogic XLR/XLS network device"
> +     depends on CPU_XLR

Why will this not build on any other platform?  It should, right?


> --- /dev/null
> +++ b/drivers/staging/netlogic/TODO
> @@ -0,0 +1,5 @@
> +* Implementing 64bit stat counter in software
> +* All memory allocation should be changed to DMA allocations
> +* All the netdev should be linked to single pdev as parent
> +* Changing comments in to linux standred format
> +

I need a name and email address for who is responsible for this driver
and will be handling patches for it.

Please fix this up and resubmit.

thanks,

greg k-h

<Prev in Thread] Current Thread [Next in Thread>