linux-mips
[Top] [All Lists]

Re: MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE

To: Ben Hutchings <ben@decadent.org.uk>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 04 Mar 2013 10:13:00 -0800
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=baO/FyXIcyUKa3fS0KFD57A640/ONwrBRWlcY/VagoY=; b=JEgpPRCG51z4SSsfN/U/IsKr/6xz0gIIT4LaJYf7P3NnV/ftYpBMnUsVC/q0+QkGxi 6SXeCjB6tREGppKOPgKbRZgcTmt0tlVfr8Dn8zClr3JqNRv1jMKgXPXUyS+r3DbbIZ99 yu0Zn95ayWn0hUJ26x68ehCf2LgY9EKnFf1kraTulLBu7XpzzL/NQd59gbKYSR5BTcD3 jujO45NK4o6Yz26ghNG3v0YsVhfbO+Q4YWhawXCQiCRTxYdq2TFi6cR2TOpDecmYDGXg 1OT6WCYC159fxCspU4ofTKpaE4eGbBNzYlkfjs15FFIybbCiOYzWQDCy4AIc78hIVz6x W+1g==
In-reply-to: <1362370641.3768.291.camel@deadeye.wl.decadent.org.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362257499.3768.141.camel@deadeye.wl.decadent.org.uk> <1362370641.3768.291.camel@deadeye.wl.decadent.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
On 03/03/2013 08:17 PM, Ben Hutchings wrote:
The MIPS implementation of transparent huge-pages (THP) is 64-bit only,
and of course also requires that the CPU supports huge-pages.

Currently it's entirely possible to enable THP in other configurations,
which then fail to build due to pfn_pmd() not being defined.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: David Daney <david.daney@cavium.com>

This is correct.

Acked-by: David Daney <david.daney@cavium.com>


---
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -19,7 +19,7 @@ config MIPS
        select HAVE_KRETPROBES
        select HAVE_DEBUG_KMEMLEAK
        select ARCH_BINFMT_ELF_RANDOMIZE_PIE
-       select HAVE_ARCH_TRANSPARENT_HUGEPAGE
+       select HAVE_ARCH_TRANSPARENT_HUGEPAGE if CPU_SUPPORTS_HUGEPAGES && 64BIT
        select RTC_LIB if !MACH_LOONGSON
        select GENERIC_ATOMIC64 if !64BIT
        select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE



<Prev in Thread] Current Thread [Next in Thread>