Re: MIPS: Add dependencies for HAVE_ARCH_TRANSPARENT_HUGEPAGE

[David Daney <ddaney.cavm@gmail.com>]

On 03/03/2013 08:17 PM, Ben Hutchings wrote:
> The MIPS implementation of transparent huge-pages (THP) is 64-bit only,
> and of course also requires that the CPU supports huge-pages.
>
> Currently it's entirely possible to enable THP in other configurations,
> which then fail to build due to pfn_pmd() not being defined.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: David Daney <david.daney@cavium.com>
This is correct.

Acked-by: David Daney <david.daney@cavium.com>


> ---
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -19,7 +19,7 @@ config MIPS
>         select HAVE_KRETPROBES
>         select HAVE_DEBUG_KMEMLEAK
>         select ARCH_BINFMT_ELF_RANDOMIZE_PIE
> -       select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> +       select HAVE_ARCH_TRANSPARENT_HUGEPAGE if CPU_SUPPORTS_HUGEPAGES && 64BIT
>         select RTC_LIB if !MACH_LOONGSON
>         select GENERIC_ATOMIC64 if !64BIT
>         select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE