linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Netlogic: Platform changes for XLR/XLS gmac

To: ganesanr@broadcom.com
Subject: Re: [PATCH 2/2] MIPS: Netlogic: Platform changes for XLR/XLS gmac
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sat, 2 Mar 2013 10:48:08 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=/dSbBwUWOWf0bqffL/B41ncMCfndSPvxQ3JZiMFKfN8=; b=g+/fe5ly0Oc48yJbYvLRgCVWNVgwmvSDZaoC43HIO847h7N65lXgQDmcCEKhyLdoQH 6IKUwMJvI2xew1btYKg5IgT5pPeh9pKkCpvJC90dV4eC4/CycW/+bS9u8aU9WTqZZTXw WSYCrWagxt9ZOaGpHzSjP7SF1JCxcdyi8g7Vs=
In-reply-to: <1362249374-25556-2-git-send-email-ganesanr@broadcom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1362249374-25556-1-git-send-email-ganesanr@broadcom.com> <1362249374-25556-2-git-send-email-ganesanr@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Mar 03, 2013 at 12:06:14AM +0530, ganesanr@broadcom.com wrote:
> From: Ganesan Ramalingam <ganesanr@broadcom.com>
> 
> Add platform code to create network interface (xlr-net) for XLR/XLS
> boards.
> 
> Signed-off-by: Ganesan Ramalingam <ganesanr@broadcom.com>
> ---
>  This patch has be merged via linux-mips tree.
> 
>  This patch depends on [PATCH 1/2] Staging: Netlogic XLR/XLS GMAC driver.
> 
>  arch/mips/include/asm/netlogic/xlr/platform_net.h |   46 +++++
>  arch/mips/netlogic/xlr/Makefile                   |    3 +-
>  arch/mips/netlogic/xlr/fmn.c                      |    2 +
>  arch/mips/netlogic/xlr/platform_net.c             |  222 
> +++++++++++++++++++++
>  4 files changed, 272 insertions(+), 1 deletions(-)
>  create mode 100644 arch/mips/include/asm/netlogic/xlr/platform_net.h
>  create mode 100644 arch/mips/netlogic/xlr/platform_net.c

Staging drivers should be stand-alone, not depending on changes
elsewhere in the tree.  Why not either merge these into the staging
driver, or move the driver to the correct place to start with?

thanks,

greg k-h

<Prev in Thread] Current Thread [Next in Thread>