linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: sead3_led: Use LED_CORE_SUSPENDRESUME

To: Steven Hill <Steven.Hill@imgtec.com>
Subject: Re: [PATCH] MIPS: sead3_led: Use LED_CORE_SUSPENDRESUME
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Wed, 20 Feb 2013 21:42:25 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Kristian Kielhofner <kris@krisk.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
In-reply-to: <0573B2AE5BBFFC408CC8740092293B5ACB3CB7@bamail02.ba.imgtec.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1361104102-13294-1-git-send-email-lars@metafoo.de> <0573B2AE5BBFFC408CC8740092293B5ACB3CB7@bamail02.ba.imgtec.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20121215 Icedove/3.0.11
On 02/20/2013 09:31 PM, Steven Hill wrote:
> Hello.
> 
> This patch does not apply cleanly because of space/tab differences. In both 
> of the lines below with '.brightness_set' the character between 't' and '=' 
> needs to be a tab, not a space.
> 
> -Steve

Hi,

The patch depends on commit 70342287 ("MIPS: Whitespace cleanup.").

- Lars



> 
> 
> @@ -34,33 +34,15 @@ static void sead3_fled_set(struct led_classdev *led_cdev,
>  static struct led_classdev sead3_pled = {
>          .name           = "sead3::pled",
>          .brightness_set = sead3_pled_set,
> +       .flags          = LED_CORE_SUSPENDRESUME,
>  };
>  
>  static struct led_classdev sead3_fled = {
>          .name           = "sead3::fled",
>          .brightness_set = sead3_fled_set,
> +       .flags          = LED_CORE_SUSPENDRESUME,
>  };
> 


<Prev in Thread] Current Thread [Next in Thread>