| To: | liguang <lig.fnst@cn.fujitsu.com> |
|---|---|
| Subject: | Re: [PATCH] mips: remove unecessary __linux__ check |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 19 Feb 2013 11:04:25 +0100 |
| Cc: | linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
| In-reply-to: | <1361261571-1556-1-git-send-email-lig.fnst@cn.fujitsu.com> |
| List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
| List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
| List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
| List-owner: | <mailto:ralf@linux-mips.org> |
| List-post: | <mailto:linux-mips@linux-mips.org> |
| List-software: | Ecartis version 1.0.0 |
| List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
| List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
| References: | <1361261571-1556-1-git-send-email-lig.fnst@cn.fujitsu.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 19, 2013 at 04:12:51PM +0800, liguang wrote: > sgidefs.h has strict check for __linux__, > it seems too harsh, as far as I test, 2 cross > compiler for mips will not define it automatically, > and exit build process with error > "#error Use a Linux compiler or give up". > remove it will not hurt, I think. My mailbox used to get flooded by people who attempted to build a kernel using something like a mips-elf, mips-sde-elf or even stranger targets. There are further differences than just the definition of __linux__ so I eventually applied this check. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] mips: remove unecessary __linux__ check, liguang |
|---|---|
| Next by Date: | Re: Upcoming cross-tree build breakage on merge window, John Crispin |
| Previous by Thread: | [PATCH] mips: remove unecessary __linux__ check, liguang |
| Next by Thread: | Re: Upcoming cross-tree build breakage on merge window, John Crispin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |