Re: [PATCH v2 09/18] KVM/MIPS32: COP0 accesses profiling.

[Sanjay Lal <sanjayl@kymasys.com>]

On Feb 6, 2013, at 8:17 AM, Gleb Natapov wrote:

> On Wed, Nov 21, 2012 at 06:34:07PM -0800, Sanjay Lal wrote:
>> 
>> +int kvm_mips_dump_stats(struct kvm_vcpu *vcpu)
>> +{
>> +    int i, j __unused;
>> +#ifdef CONFIG_KVM_MIPS_DEBUG_COP0_COUNTERS
>> +    printk("\nKVM VCPU[%d] COP0 Access Profile:\n", vcpu->vcpu_id);
>> +    for (i = 0; i < N_MIPS_COPROC_REGS; i++) {
>> +            for (j = 0; j < N_MIPS_COPROC_SEL; j++) {
>> +                    if (vcpu->arch.cop0->stat[i][j])
>> +                            printk("%s[%d]: %lu\n", kvm_cop0_str[i], j,
>> +                                   vcpu->arch.cop0->stat[i][j]);
>> +            }
>> +    }
>> +#endif
>> +
>> +    return 0;
>> +}
> You need to use ftrace event for that. Much more flexible with perf
> integration and no need to recompile to enabled/disable.
> 
> --
>                       Gleb.

Agreed, I'll start using trace for keeping track of COP0 accesses.

Regards
Sanjay