Re: [PATCH 04/11] MIPS: ath79: add IRQ handling code for the QCA955X SoCs

[John Crispin <blogic@openwrt.org>]

>         if (soc_is_ar71xx() || soc_is_ar913x())
>                 ath79_misc_irq_chip.irq_mask_ack = ar71xx_misc_irq_mask;
> -       else if (soc_is_ar724x() || soc_is_ar933x() || soc_is_ar934x())
> +       else if (soc_is_ar724x() ||
> +                soc_is_ar933x() ||
> +                soc_is_ar934x() ||
> +                soc_is_qca955x())
>                 ath79_misc_irq_chip.irq_ack = ar724x_misc_irq_ack;
Hi,

the list is getting long. not a blocker but might be worth thinking of a 
different way to solve the different revisions of the irq core

> +       if (status&  QCA955X_EXT_INT_USB1) {
> +               /* TODO: flush DDR? */
> +               generic_handle_irq(ATH79_IP3_IRQ(0));
> +       }
> +
> +       if (status&  QCA955X_EXT_INT_USB2) {
> +               /* TODO: flsuh DDR? */
> +               generic_handle_irq(ATH79_IP3_IRQ(1));
> +       }
flsuh typo


    John