linux-mips
[Top] [All Lists]

Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/excep

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.
From: Gleb Natapov <gleb@redhat.com>
Date: Wed, 6 Feb 2013 15:20:18 +0200
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1353551656-23579-12-git-send-email-sanjayl@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1353551656-23579-1-git-send-email-sanjayl@kymasys.com> <1353551656-23579-12-git-send-email-sanjayl@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote:
> +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva)
> +{
> +     gpa_t gpa;
> +     uint32_t kseg = KSEGX(gva);
> +
> +     if ((kseg == CKSEG0) || (kseg == CKSEG1))
You seems to be using KVM_GUEST_KSEGX variants on gva in all other
places. Why not here?

> +             gpa = CPHYSADDR(gva);
> +     else {
> +             printk("%s: cannot find GPA for GVA: %#lx\n", __func__, gva);
> +             kvm_mips_dump_host_tlbs();
> +             gpa = KVM_INVALID_ADDR;
> +     }
> +
> +#ifdef DEBUG
> +     kvm_debug("%s: gva %#lx, gpa: %#llx\n", __func__, gva, gpa);
> +#endif
> +
> +     return gpa;
> +}
> +

--
                        Gleb.

<Prev in Thread] Current Thread [Next in Thread>