Re: [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.

[Gleb Natapov <gleb@redhat.com>]

On Wed, Nov 21, 2012 at 06:34:09PM -0800, Sanjay Lal wrote:
> +static gpa_t kvm_trap_emul_gva_to_gpa_cb(gva_t gva)
> +{
> +     gpa_t gpa;
> +     uint32_t kseg = KSEGX(gva);
> +
> +     if ((kseg == CKSEG0) || (kseg == CKSEG1))
You seems to be using KVM_GUEST_KSEGX variants on gva in all other
places. Why not here?

> +             gpa = CPHYSADDR(gva);
> +     else {
> +             printk("%s: cannot find GPA for GVA: %#lx\n", __func__, gva);
> +             kvm_mips_dump_host_tlbs();
> +             gpa = KVM_INVALID_ADDR;
> +     }
> +
> +#ifdef DEBUG
> +     kvm_debug("%s: gva %#lx, gpa: %#llx\n", __func__, gva, gpa);
> +#endif
> +
> +     return gpa;
> +}
> +

--
                        Gleb.