linux-mips
[Top] [All Lists]

Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures.

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures.
From: Gleb Natapov <gleb@redhat.com>
Date: Wed, 6 Feb 2013 15:11:14 +0200
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1353551656-23579-3-git-send-email-sanjayl@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1353551656-23579-1-git-send-email-sanjayl@kymasys.com> <1353551656-23579-3-git-send-email-sanjayl@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Nov 21, 2012 at 06:34:00PM -0800, Sanjay Lal wrote:
> +struct kvm_mips_callbacks {
> +     int (*handle_cop_unusable) (struct kvm_vcpu *vcpu);
> +     int (*handle_tlb_mod) (struct kvm_vcpu *vcpu);
> +     int (*handle_tlb_ld_miss) (struct kvm_vcpu *vcpu);
> +     int (*handle_tlb_st_miss) (struct kvm_vcpu *vcpu);
> +     int (*handle_addr_err_st) (struct kvm_vcpu *vcpu);
> +     int (*handle_addr_err_ld) (struct kvm_vcpu *vcpu);
> +     int (*handle_syscall) (struct kvm_vcpu *vcpu);
> +     int (*handle_res_inst) (struct kvm_vcpu *vcpu);
> +     int (*handle_break) (struct kvm_vcpu *vcpu);
> +     int (*vm_init) (struct kvm *kvm);
> +     int (*vcpu_init) (struct kvm_vcpu *vcpu);
> +     int (*vcpu_setup) (struct kvm_vcpu *vcpu);
> +      gpa_t(*gva_to_gpa) (gva_t gva);
> +     void (*queue_timer_int) (struct kvm_vcpu *vcpu);
> +     void (*dequeue_timer_int) (struct kvm_vcpu *vcpu);
> +     void (*queue_io_int) (struct kvm_vcpu *vcpu,
> +                           struct kvm_mips_interrupt *irq);
> +     void (*dequeue_io_int) (struct kvm_vcpu *vcpu,
> +                             struct kvm_mips_interrupt *irq);
> +     int (*irq_deliver) (struct kvm_vcpu *vcpu, unsigned int priority,
> +                         uint32_t cause);
> +     int (*irq_clear) (struct kvm_vcpu *vcpu, unsigned int priority,
> +                       uint32_t cause);
> +     int (*vcpu_ioctl_get_regs) (struct kvm_vcpu *vcpu,
> +                                 struct kvm_regs *regs);
> +     int (*vcpu_ioctl_set_regs) (struct kvm_vcpu *vcpu,
> +                                 struct kvm_regs *regs);
> +};
You haven't addressed Avi's comment about dropping the interaction and
adding it later, when other HW is supported and the best way to do the split
is known.

--
                        Gleb.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures., Gleb Natapov <=