| To: | David Daney <ddaney.cavm@gmail.com> |
|---|---|
| Subject: | RE: [PATCH][RFC] MIPS: microMIPS: Add support to micro-assembler. |
| From: | "Hill, Steven" <sjhill@mips.com> |
| Date: | Mon, 4 Feb 2013 16:06:39 +0000 |
| Accept-language: | en-US |
| Cc: | "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>, "cernekee@gmail.com" <cernekee@gmail.com> |
| In-reply-to: | <510960B9.1060800@gmail.com> |
| List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
| List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
| List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
| List-owner: | <mailto:ralf@linux-mips.org> |
| List-post: | <mailto:linux-mips@linux-mips.org> |
| List-software: | Ecartis version 1.0.0 |
| List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
| List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
| References: | <1359514228-2161-1-git-send-email-sjhill@mips.com>,<510960B9.1060800@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| Thread-index: | AQHN/pSXpmmHN005Y0SyRQVcOld1K5hisX+AgAcyAHs= |
| Thread-topic: | [PATCH][RFC] MIPS: microMIPS: Add support to micro-assembler. |
> I wonder if we could get rid of most of these #ifdefs by taking the
> approach used in scripts/recordmcount.{c,h} or scripts/sortextable.{c,h}
>
I do not see how these are at all applicable. I am not going to modify any
compiled
ELF binary.
> That is, move all the code that varies between microMIPS and MIPS to an
> included file. At the top of that file have a single
> #if...#else...#endif block that defines the constants for each variety.
>
> Then include this file as many times as needed (once or twice) to
> produce the definitions required.
>
> This would allow both a MIPS and microMIPS uasm to exist in the same kernel.
>
I did this already did this once before in the
<http://patchwork.linux-mips.org/patch/4688/> patch. The only modification of
the patch would be to get rid of CONFIG_CPU_MICROMIPS controlling the inclusion
of the 'uasm-micromips' and to include it unconditionally. Comments?
-Steve
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/4] MIPS: pci-ar724x: remove static PCI IO/MEM resources, Gabor Juhos |
|---|---|
| Next by Date: | [tip:irq/core] arch Kconfig: Remove references to IRQ_PER_CPU, tip-bot for James Hogan |
| Previous by Thread: | [PATCH RESEND 1/1] arch Kconfig: remove references to IRQ_PER_CPU, James Hogan |
| Next by Thread: | Re: [PATCH 1/2] NET: ethernet/netlogic: Netlogic XLR/XLS GMAC driver, Ganesan Ramalignam |
| Indexes: | [Date] [Thread] [Top] [All Lists] |