linux-mips
[Top] [All Lists]

Re: [PATCH V3 09/10] MIPS: ralink: adds rt305x devicetree

To: linux-mips@linux-mips.org
Subject: Re: [PATCH V3 09/10] MIPS: ralink: adds rt305x devicetree
From: John Crispin <john@phrozen.org>
Date: Thu, 31 Jan 2013 14:13:22 +0100
In-reply-to: <510A6ABB.2090800@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1359633561-4980-1-git-send-email-blogic@openwrt.org> <1359633561-4980-10-git-send-email-blogic@openwrt.org> <510A6ABB.2090800@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7

The specific partition mapping definitively belongs to a rt305x-eval.dts
file and not a dtsi you would create.

I’ll split this into 2 files


+};
diff --git a/arch/mips/ralink/rt305x.c b/arch/mips/ralink/rt305x.c
index 1e24439..f4b2e4d 100644
--- a/arch/mips/ralink/rt305x.c
+++ b/arch/mips/ralink/rt305x.c
@@ -185,8 +185,8 @@ void __init ralink_clk_init(void)

void __init ralink_of_remap(void)
{
- rt_sysc_membase = plat_of_remap_node("ralink,rt305x-sysc");
- rt_memc_membase = plat_of_remap_node("ralink,rt305x-memc");
+ rt_sysc_membase = plat_of_remap_node("ralink,rt3052-sysc");
+ rt_memc_membase = plat_of_remap_node("ralink,rt3052-memc");

Why are you doing this? If you specify multiple compatible properties,
such as:
compatible = "ralink,rt3052-sysc", "ralink,rt305x-sysc" you should be
good in any case no?


I folded that fix into the wrong patch :-)


using wild cards is discouraged for compatible strings rt3052 was the first silicon with this sysc version.

        John



<Prev in Thread] Current Thread [Next in Thread>