linux-mips
[Top] [All Lists]

Re: [PATCH V3 08/10] MIPS: ralink: adds support for RT305x SoC family

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V3 08/10] MIPS: ralink: adds support for RT305x SoC family
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 31 Jan 2013 14:06:29 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Nsp2EjXQTxY91DQS8ZtQ7+tPQrE8QPyykAaafJAZb54=; b=Y21jx78Pf0QWfILOabTUymHPORzHVUq20odEFGJ+hrYG8VlriMRaQGDT0uLeyUgvv0 G9X9rqkC56UwzwQ6iTkA2xj965ODedxtyFMsM/bjQkxN8vOA7Wgbez1Arpwt3Ws2G5K1 QUQtD4SRbo+G5dV9OPZrsPKCRIH4ghP1UaQje6fmocP43CXbeWAEx6Fpc7lYkoxcWfkv sPxzoFsWlN2/F9JhQ250z1itr999ojsGuFCwz+2JaPtSWoBbX8Cr5u+0AwiWJ9ec9+3b pWxUxzPEvzGyv1yrAkOt7q0P/HR+Nyhi8oqmxdwZu/7i9xl37p0Yh3zvTyZv7DmZ45NJ PxVQ==
In-reply-to: <1359633561-4980-9-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1359633561-4980-1-git-send-email-blogic@openwrt.org> <1359633561-4980-9-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
Hello John,

On 01/31/2013 12:59 PM, John Crispin wrote:
[snip]

+
+struct ralink_pinmux gpio_pinmux = {
+       .mode = mode_mux,
+       .uart = uart_mux,
+       .uart_shift = RT305X_GPIO_MODE_UART0_SHIFT,
+       .wdt_reset = rt305x_wdt_reset,
+};

It seems to me like the new convention for pinctrl/pinmux etc .. is to actually create drivers/pinctrl/pinctrl-ralink.c and drivers/pinctrl/pinctrl-rt305x.c, I guess this can be done later when you come up with support for the other Ralink SoCs.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>