linux-mips
[Top] [All Lists]

Re: [PATCH V3 10/10] MIPS: ralink: adds Kbuild files

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH V3 10/10] MIPS: ralink: adds Kbuild files
From: John Crispin <blogic@openwrt.org>
Date: Thu, 31 Jan 2013 13:57:40 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <510A6A17.5050003@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1359633561-4980-1-git-send-email-blogic@openwrt.org> <1359633561-4980-11-git-send-email-blogic@openwrt.org> <510A6A17.5050003@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7
On 31/01/13 13:56, Florian Fainelli wrote:
Hello John,

On 01/31/2013 12:59 PM, John Crispin wrote:
[snip]

  config MIPS_L1_CACHE_SHIFT
      int
- default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL + default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL || RALINK_RT288X

I got slightly confused here because this is actually ok, RALINK_RT288X should have MIPS_L1_CACHE_SHIFT=4, but rt305x and rt3883 have MIPS_L1_CACHE_SHIFT=5. So I would drop this hunk until you add support for rt288x.
--
Florian



yes i forgot that bit

    John

<Prev in Thread] Current Thread [Next in Thread>