linux-mips
[Top] [All Lists]

Re: [PATCH V3 10/10] MIPS: ralink: adds Kbuild files

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V3 10/10] MIPS: ralink: adds Kbuild files
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 31 Jan 2013 13:56:55 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=z232m/0O7xHKvfRjLEJ+X0rLc3wVtUmCSlRW3GS15Hc=; b=U7BSJIlpcD0FNWoyxC3WyX/pGvqpCycC72RxjyK8Wkycj3oCjH0xtqXDJa3hhYxlEC +MduSmjX2YWcerejHEtrrsETaj9nIGLwxNmWkAWQzT6MmZXD3dzZt2sdiQLaskhP963p RgyhRxPTMRK/qgmpWiEpABRy5Mpo+SIBC2hSeHidkFKzwjxZ+/ltHMx30JVVjjjo81jy ji7F81bLOnK67N7eZlf4W840ls4l8s3Yq4U5w1rZea5udnrTSIvC7SFaNzy/9+lKjAhq tRiM6KFteFQUKOw9pQdC7Q0sCMfSagLVEmUXEKL6s84+ewQ2eLTOULPiyh/tIgr0SygL QraA==
In-reply-to: <1359633561-4980-11-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1359633561-4980-1-git-send-email-blogic@openwrt.org> <1359633561-4980-11-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
Hello John,

On 01/31/2013 12:59 PM, John Crispin wrote:
[snip]

  config MIPS_L1_CACHE_SHIFT
        int
-       default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL
+       default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL || 
RALINK_RT288X

I got slightly confused here because this is actually ok, RALINK_RT288X should have MIPS_L1_CACHE_SHIFT=4, but rt305x and rt3883 have MIPS_L1_CACHE_SHIFT=5. So I would drop this hunk until you add support for rt288x.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>