linux-mips
[Top] [All Lists]

Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private regi

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register
From: Felipe Balbi <balbi@ti.com>
Date: Tue, 29 Jan 2013 09:37:35 +0200
Cc: <linux-mips@linux-mips.org>, <balbi@ti.com>, <ralf@linux-mips.org>, <jogo@openwrt.org>, <mbizon@freebox.fr>, <cernekee@gmail.com>, <linux-usb@vger.kernel.org>, <stern@rowland.harvard.edu>, <gregkh@linuxfoundation.org>, <blogic@openwrt.org>
In-reply-to: <2622165.icySTsWGzL@bender>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1359399991-2236-1-git-send-email-florian@openwrt.org> <1359399991-2236-4-git-send-email-florian@openwrt.org> <20130128204114.GA5509@arwen.pp.htv.fi> <2622165.icySTsWGzL@bender>
Reply-to: <balbi@ti.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
Hi,

On Mon, Jan 28, 2013 at 10:17:15PM +0100, Florian Fainelli wrote:
> On Monday 28 January 2013 22:41:14 Felipe Balbi wrote:
> > Hi,
> > 
> > On Mon, Jan 28, 2013 at 08:06:21PM +0100, Florian Fainelli wrote:
> > > diff --git a/drivers/usb/gadget/bcm63xx_udc.c 
> > > b/drivers/usb/gadget/bcm63xx_udc.c
> > > index ad17533..af450c4 100644
> > > --- a/drivers/usb/gadget/bcm63xx_udc.c
> > > +++ b/drivers/usb/gadget/bcm63xx_udc.c
> > > @@ -41,6 +41,7 @@
> > >  #include <bcm63xx_dev_usb_usbd.h>
> > >  #include <bcm63xx_io.h>
> > >  #include <bcm63xx_regs.h>
> > > +#include <bcm63xx_usb_priv.h>
> > 
> > actually, I want to see this arch dependency vanish. The whole
> > "phy_mode" stuff should be a PHY driver, care to implement this properly
> > using the PHY layer ?
> 
> Ok, but then I won't be able to use the generic OHCI and EHCI platform drivers
> because they are not yet aware of clocks, PHY slave device etc... For now I
> would like to stick with that since this is also very BCM63xx centric.
> 
> Would that be ok with you?

sure, but we need to see a move towards making all of this generic and,
perhaps more importantly (at least to me), compilable on all arches so
we can make proper use of linux-next and Fengguang's build systems.

-- 
balbi

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>