[Top] [All Lists]

Re: [PATCH v4 0/5] watchdog: bcm47xx_wdt.c: add support for SoCs with PM

To: Wim Van Sebroeck <>
Subject: Re: [PATCH v4 0/5] watchdog: bcm47xx_wdt.c: add support for SoCs with PMU
From: Hauke Mehrtens <>
Date: Mon, 28 Jan 2013 23:06:03 +0100
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
On 01/28/2013 10:35 PM, Wim Van Sebroeck wrote:
> Hi Hauke,
>> what is the status of these patches?
> First reading/checking (v4+v5) seems OK.
> 1 small remark allready: the settimeout functions seem to check the min and 
> max timeout values.
> Can't you use the min and max values of the watchdog structure for this?
> Kind regards,
> Wim.
Hi Wim,

The max_timer_ms attribute in struct bcm47xx_wdt contains the maximum
value the hardware is capable of, the watchdog driver uses a softtimer
if this value is too low and in that case it is no problem if a
userspace application sets the timeout to some value higher than

If I would use max_timeout from struct watchdog_device I would have to
change that values when softtimer is selected.

The best solution would be if the softtimer choice and implementation
would go to watchdog_dev.c as some more watchdog driver do something


<Prev in Thread] Current Thread [Next in Thread>