linux-mips
[Top] [All Lists]

Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private regi

To: linux-mips@linux-mips.org, balbi@ti.com
Subject: Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 28 Jan 2013 22:17:15 +0100
Cc: ralf@linux-mips.org, jogo@openwrt.org, mbizon@freebox.fr, cernekee@gmail.com, linux-usb@vger.kernel.org, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, blogic@openwrt.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Zv0/kz0UU0b2zfpQoIgq5br3HZBKVjzFcnAHuoc3CBk=; b=uxqVuWKfo5eU0f7MOzA1LI/WegNHlXwKF9YUmsq3jnWCEhutWkgvo9MeO1thxS17Yj UHnWsWiGR2SRnz1ebqAEkVwVMWOzZ66i0Y1rAb/6/tc5DBN+qx1ujeebqmj7Ahh64aSe W+plnOGKBKUvEgh/N26Lg8++JdCTgvPbBUFVbUD+I7e1MxYnrrwruGYuwLXr5BpkQcQq Nu1YXkD/d1og6a5YVoJ0RoACXu7uUousl5+qjrwiry2/S8yXjA8VcwHolG5KUdKdU4rU vkOO4FmbQDXCIYssg0NZkifPLXq3gCMaqSSvHLArdjQKDbu5J9l1jsrNV6waFEnUpoAf Mh9A==
In-reply-to: <20130128204114.GA5509@arwen.pp.htv.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1359399991-2236-1-git-send-email-florian@openwrt.org> <1359399991-2236-4-git-send-email-florian@openwrt.org> <20130128204114.GA5509@arwen.pp.htv.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.9.4 (Linux/3.5.0-22-generic; KDE/4.9.4; x86_64; ; )
On Monday 28 January 2013 22:41:14 Felipe Balbi wrote:
> Hi,
> 
> On Mon, Jan 28, 2013 at 08:06:21PM +0100, Florian Fainelli wrote:
> > diff --git a/drivers/usb/gadget/bcm63xx_udc.c 
> > b/drivers/usb/gadget/bcm63xx_udc.c
> > index ad17533..af450c4 100644
> > --- a/drivers/usb/gadget/bcm63xx_udc.c
> > +++ b/drivers/usb/gadget/bcm63xx_udc.c
> > @@ -41,6 +41,7 @@
> >  #include <bcm63xx_dev_usb_usbd.h>
> >  #include <bcm63xx_io.h>
> >  #include <bcm63xx_regs.h>
> > +#include <bcm63xx_usb_priv.h>
> 
> actually, I want to see this arch dependency vanish. The whole
> "phy_mode" stuff should be a PHY driver, care to implement this properly
> using the PHY layer ?

Ok, but then I won't be able to use the generic OHCI and EHCI platform drivers
because they are not yet aware of clocks, PHY slave device etc... For now I
would like to stick with that since this is also very BCM63xx centric.

Would that be ok with you?
-- 
Florian

<Prev in Thread] Current Thread [Next in Thread>