linux-mips
[Top] [All Lists]

Re: [PATCH 08/13] MIPS: BCM63XX: introduce BCM63XX_EHCI configuration sy

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 08/13] MIPS: BCM63XX: introduce BCM63XX_EHCI configuration symbol
From: Alan Stern <stern@rowland.harvard.edu>
Date: Mon, 28 Jan 2013 15:15:29 -0500 (EST)
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-usb@vger.kernel.org>, <gregkh@linuxfoundation.org>, <linux-mips@linux-mips.org>, <ralf@linux-mips.org>, <jogo@openwrt.org>, <mbizon@freebox.fr>, <blogic@openwrt.org>
In-reply-to: <5106D80C.7050508@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 28 Jan 2013, Florian Fainelli wrote:

> >> --- a/drivers/usb/host/Kconfig
> >> +++ b/drivers/usb/host/Kconfig
> >> @@ -115,14 +115,15 @@ config USB_EHCI_BIG_ENDIAN_MMIO
> >>       depends on USB_EHCI_HCD && (PPC_CELLEB || PPC_PS3 || 440EPX || \
> >>                       ARCH_IXP4XX || XPS_USB_HCD_XILINX || \
> >>                       PPC_MPC512x || CPU_CAVIUM_OCTEON || \
> >> -                    PMC_MSP || SPARC_LEON || MIPS_SEAD3)
> >> +                    PMC_MSP || SPARC_LEON || MIPS_SEAD3 || \
> >> +                    BCM63XX)
> >>       default y
> >
> > This is a complete mess.
> >
> > Can we get rid of the 'default y' and all those things after the '&&',
> > and select USB_EHCI_BIG_ENDIAN_MMIO in the board Kconfig files?
> 
> Yes, pretty much like what exists for OHCI, scales much better.
> 
> >
> > I am as guilty as anyone here (see || CPU_CAVIUM_OCTEON above).  But
> > this doesn't seem sustainable.  We should be trying to keep the
> > configuration information for all this in one spot.
> >
> > Now you have it spread across two files.  One to enable it, and the
> > other to select it.  But do you really need to select it if it defaults
> > to 'y'
> 
> I do agree with you, but I don't want this patchset to be blocked by the 
> removal of the depends on (FOO && BAR && ...), but I can send a 
> preliminary patch for this and get it merged with Greg's tree first.

If you decide to do this, consider the discussion starting here:

        http://marc.info/?l=linux-usb&m=135886919810940&w=2

As far as I know, there is no good reason for keeping the 
USB_ARCH_HAS_EHCI symbol at all.  And the glue drivers can select 
USB_EHCI_HCD instead of depending on it.

Alan Stern


<Prev in Thread] Current Thread [Next in Thread>