linux-mips
[Top] [All Lists]

Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64

To: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: Sat, 26 Jan 2013 23:19:30 +0200
Cc: LKML <linux-kernel@vger.kernel.org>, linux-mips <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <1359234104.17639.2.camel@gandalf.local.home>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1359137595.21576.246.camel@gandalf.local.home> <20130126201541.GF23053@blackmetal.musicnaut.iki.fi> <1359234104.17639.2.camel@gandalf.local.home>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
Hi,

On Sat, Jan 26, 2013 at 04:01:44PM -0500, Steven Rostedt wrote:
> On Sat, 2013-01-26 at 22:15 +0200, Aaro Koskinen wrote:
> > On Fri, Jan 25, 2013 at 01:13:15PM -0500, Steven Rostedt wrote:
> > > Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
> > > virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
> > > file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
> > > 32, and not for MIPS 64.
> > > 
> > > When compiling for my yeeloong2, which supposedly supports hibernation,
> > > which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
> > > got this error:
> > 
> > This has been reported also here:
> > 
> >     http://marc.info/?l=linux-mips&m=135788867604856&w=2
> > 
> > and here:
> > 
> >     http://marc.info/?l=linux-mips&m=135876719403187&w=2
> > 
> 
> Hmm, interesting. Although, I prefer my change as it doesn't require
> compiling all of ioremap.c where it's not needed.

Yes, I think your solution is fine.

A.

<Prev in Thread] Current Thread [Next in Thread>