Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 2013-01-26 at 22:15 +0200, Aaro Koskinen wrote:
> Hi,
> 
> On Fri, Jan 25, 2013 at 01:13:15PM -0500, Steven Rostedt wrote:
> > Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
> > virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
> > file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
> > 32, and not for MIPS 64.
> > 
> > When compiling for my yeeloong2, which supposedly supports hibernation,
> > which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
> > got this error:
> 
> This has been reported also here:
> 
>       http://marc.info/?l=linux-mips&m=135788867604856&w=2
> 
> and here:
> 
>       http://marc.info/?l=linux-mips&m=135876719403187&w=2
> 

Hmm, interesting. Although, I prefer my change as it doesn't require
compiling all of ioremap.c where it's not needed.

> It's pretty sad that MIPS has been pretty much broken during the whole
> 3.8-rc cycle. :-(
> 

Yeah, that happens.

-- Steve