Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64

To:	Steven Rostedt <rostedt@goodmis.org>
Subject:	Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64
From:	Aaro Koskinen <aaro.koskinen@iki.fi>
Date:	Sat, 26 Jan 2013 22:15:41 +0200
Cc:	LKML <linux-kernel@vger.kernel.org>, linux-mips <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to:	<1359137595.21576.246.camel@gandalf.local.home>
List-archive:	<http://www.linux-mips.org/archives/linux-mips/>
List-help:	<mailto:ecartis@linux-mips.org?Subject=help>
List-id:	linux-mips <linux-mips.eddie.linux-mips.org>
List-owner:	<mailto:ralf@linux-mips.org>
List-post:	<mailto:linux-mips@linux-mips.org>
List-software:	Ecartis version 1.0.0
List-subscribe:	<mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe:	<mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References:	<1359137595.21576.246.camel@gandalf.local.home>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.21 (2010-09-15)

Hi,

On Fri, Jan 25, 2013 at 01:13:15PM -0500, Steven Rostedt wrote:
> Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
> virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
> file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
> 32, and not for MIPS 64.
> 
> When compiling for my yeeloong2, which supposedly supports hibernation,
> which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
> got this error:

This has been reported also here:

        http://marc.info/?l=linux-mips&m=135788867604856&w=2

and here:

        http://marc.info/?l=linux-mips&m=135876719403187&w=2

It's pretty sad that MIPS has been pretty much broken during the whole
3.8-rc cycle. :-(

A.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Aaro Koskinen <= Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Aaro Koskinen

Previous by Date:	[PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt
Next by Date:	Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt
Previous by Thread:	[PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt
Next by Thread:	Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64, Steven Rostedt
Indexes:	[Date] [Thread] [Top] [All Lists]