linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] serial: ralink: adds support for the serial core found o

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 1/2] serial: ralink: adds support for the serial core found on ralink wisoc
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 25 Jan 2013 15:40:56 +0400
Cc: Alan Cox <alan@linux.intel.com>, linux-serial@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1359111008-9998-1-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1359111008-9998-1-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
Hello.

On 25-01-2013 14:50, John Crispin wrote:

The MIPS based Ralink WiSoC platform has 1 or more 8250 compatible serial cores.
To make them work we require the same quirks that are used by AU1x00.

Signed-off-by: John Crispin <blogic@openwrt.org>
---
  drivers/tty/serial/8250/8250.c  |    6 +++---
  drivers/tty/serial/8250/Kconfig |    8 ++++++++
  include/linux/serial_core.h     |    2 +-
  3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
index f932043..b727779 100644
--- a/drivers/tty/serial/8250/8250.c
+++ b/drivers/tty/serial/8250/8250.c
@@ -324,9 +324,9 @@ static void default_serial_dl_write(struct uart_8250_port 
*up, int value)
        serial_out(up, UART_DLM, value >> 8 & 0xff);
  }

-#ifdef CONFIG_MIPS_ALCHEMY
+#if defined(CONFIG_MIPS_ALCHEMY) || defined(CONFIG_SERIAL_8250_RT288X)

-/* Au1x00 UART hardware has a weird register layout */
+/* Au1x00 RT288x UART hardware has a weird register layout */
            ^
   You need either comma or slash or "and" between those...

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>