linux-mips
[Top] [All Lists]

Re: [PATCH v2 00/18] KVM for MIPS32 Processors

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2 00/18] KVM for MIPS32 Processors
From: Sanjay Lal <sanjayl@kymasys.com>
Date: Thu, 24 Jan 2013 10:59:00 -0500
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20130124150518.GA1593@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1353551656-23579-1-git-send-email-sanjayl@kymasys.com> <20130124150518.GA1593@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Jan 24, 2013, at 10:05 AM, Ralf Baechle wrote:

> On Wed, Nov 21, 2012 at 06:33:58PM -0800, Sanjay Lal wrote:
> 
> I've queued the patch set.  I've done a few stylistic changes such as
> getting rid of all use of ulong and u_long data types in favor of
> unsigned long.  I also ran into the following modpost error
> 
>  ERROR: "kvm_arch_vcpu_postcreate" [arch/mips/kvm/kvm.ko] undefined!
> 
> which I fixed by adding a trivial kvm_arch_vcpu_postcreate function:
> 
> intkvm_arch_vcpu_postcreate((struct kvm_vcpu *vcpu)
> {
>        return 0;
> }
> 
> which may or may not be sufficient.
> 
> Enabling CONFIG_KVM_MIPS_VZ was causing build errors.  Since the support
> code for the VZ ASE is not part of this series, I've ripped that out
> entirely.
> 
> As for the __unused references, some are indeed unused with no apparent
> reason for why the variables shouldn't be removed.  There are also
> variables marked __unused which are being used - so no point in marking
> them.  I've sorted that, too.
> 
>  Ralf


Thanks Ralf. the kvm_arch_vcpu_postcreate() fix is fine, as are the others.

Regards
Sanjay


<Prev in Thread] Current Thread [Next in Thread>