linux-mips
[Top] [All Lists]

Re: [RFC 02/11] MIPS: ralink: adds include files

To: John Crispin <blogic@openwrt.org>
Subject: Re: [RFC 02/11] MIPS: ralink: adds include files
From: Gabor Juhos <juhosg@openwrt.org>
Date: Thu, 24 Jan 2013 11:34:04 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1358942755-25371-3-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358942755-25371-1-git-send-email-blogic@openwrt.org> <1358942755-25371-3-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
Hi John,

> Before we start adding the platform code we add the common include files.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>  arch/mips/include/asm/mach-ralink/ralink_regs.h |   39 ++++++++++++++++++++
>  arch/mips/include/asm/mach-ralink/war.h         |   25 +++++++++++++
>  arch/mips/ralink/common.h                       |   43 
> +++++++++++++++++++++++
>  3 files changed, 107 insertions(+)
>  create mode 100644 arch/mips/include/asm/mach-ralink/ralink_regs.h
>  create mode 100644 arch/mips/include/asm/mach-ralink/war.h
>  create mode 100644 arch/mips/ralink/common.h

I prefer to introduce header files along with the code which uses that actually.
Several things are defined in 'common.h' and everyone have to look into the
subseqent patches for the actual code.

<...>

> diff --git a/arch/mips/ralink/common.h b/arch/mips/ralink/common.h
> new file mode 100644
> index 0000000..8c751f5
> --- /dev/null
> +++ b/arch/mips/ralink/common.h
> @@ -0,0 +1,43 @@
> +/*
> + *  This program is free software; you can redistribute it and/or modify it
> + *  under the terms of the GNU General Public License version 2 as published
> + *  by the Free Software Foundation.
> + *
> + * Copyright (C) 2013 John Crispin <blogic@openwrt.org>
> + */
> +
> +#ifndef _RALINK_COMMON_H__
> +#define _RALINK_COMMON_H__
> +
> +#define RAMIPS_SYS_TYPE_LEN  0x100

256 bytes are too much for this IMHO. In OpenWrt we are using 64, but even 32
should be enough for every SoC.

-Gabor

<Prev in Thread] Current Thread [Next in Thread>