linux-mips
[Top] [All Lists]

Re: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

To: "Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform
From: "Arend van Spriel" <arend@broadcom.com>
Date: Mon, 21 Jan 2013 10:40:56 +0100
Cc: "Sergei Shtylyov" <sshtylyov@mvista.com>, linux-mips@linux-mips.org, "Hauke Mehrtens" <hauke@hauke-m.de>
In-reply-to: <20130116145000.GD26569@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1357323005-28008-1-git-send-email-arend@broadcom.com> <50E80F78.9030901@mvista.com> <50E9E914.9030900@broadcom.com> <20130116145000.GD26569@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
On 01/16/2013 03:50 PM, Ralf Baechle wrote:
> On Sun, Jan 06, 2013 at 10:13:56PM +0100, Arend van Spriel wrote:
> 
>>>    This change doesn';t seem to be documented in your changelog. Maybe
>>> it's worth another patch?
>>>
>>> WBR, Sergei
>>>
>>
>> Very observant. ;-) Yes. After fixing the other ones I got a warning on
>> that one. I could resubmit the change with a more generic description or
>> split it up as you suggest.
>>
>> Ralf,
>>
>> Please advice.
> 
> For simplicity's sake I'm going to split this myself BUT putting changes
> that are not explained in changelog comments is a good way to get your
> dear maintainer grumpy :)

Thanks, Ralf

Appreciated. Hope you can keep that smile ;-)

Regards,
Arend

>   Ralf
> 



<Prev in Thread] Current Thread [Next in Thread>