linux-mips
[Top] [All Lists]

Re: [PATCH v4] OF: MIPS: sead3: Implement OF support.

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH v4] OF: MIPS: sead3: Implement OF support.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 18 Jan 2013 14:24:59 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1358444223-17247-1-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358444223-17247-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 17, 2013 at 11:37:03AM -0600, Steven J. Hill wrote:

> From: "Steven J. Hill" <sjhill@mips.com>
> 
> Activate USE_OF for SEAD-3 platform. Add basic DTS file and convert
> memory detection and reservations to use OF.

Applied with this little patch on top:


 arch/mips/include/asm/mips-boards/generic.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/include/asm/mips-boards/generic.h 
b/arch/mips/include/asm/mips-boards/generic.h
index c01e286..3fc764a 100644
--- a/arch/mips/include/asm/mips-boards/generic.h
+++ b/arch/mips/include/asm/mips-boards/generic.h
@@ -20,6 +20,7 @@
 #ifndef __ASM_MIPS_BOARDS_GENERIC_H
 #define __ASM_MIPS_BOARDS_GENERIC_H
 
+#include <linux/of_fdt.h>
 #include <asm/addrspace.h>
 #include <asm/byteorder.h>
 #include <asm/mips-boards/bonito64.h>

Otherwise including generic.h might result in an error if <linux/of_fdt.h>
has not been included before.

@@ -87,9 +88,7 @@
 
 extern int mips_revision_sconid;
 
-#ifdef CONFIG_OF
 extern struct boot_param_header __dtb_start;
-#endif

There's no need to wrap this declaration.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>