linux-mips
[Top] [All Lists]

RE: [PATCH] MIPS: microMIPS: Redefine value of BRK_BUG.

To: David Daney <ddaney.cavm@gmail.com>
Subject: RE: [PATCH] MIPS: microMIPS: Redefine value of BRK_BUG.
From: "Hill, Steven" <sjhill@mips.com>
Date: Thu, 17 Jan 2013 19:07:05 +0000
Accept-language: en-US
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>
In-reply-to: <50F83FD5.2060908@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358444216-17213-1-git-send-email-sjhill@mips.com>,<50F83FD5.2060908@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AQHN9NlEm+9CcxJkN0q8N792sqGhLphOWcSA//+HK/U=
Thread-topic: [PATCH] MIPS: microMIPS: Redefine value of BRK_BUG.
>> diff --git a/arch/mips/include/asm/break.h b/arch/mips/include/asm/break.h
>> index 9161e68..df9d090 100644
>> --- a/arch/mips/include/asm/break.h
>> +++ b/arch/mips/include/asm/break.h
>> @@ -27,6 +27,7 @@
>>   #define BRK_STACKOVERFLOW 9 /* For Ada stackchecking */
>>   #define BRK_NORLD   10      /* No rld found - not used by Linux/MIPS */
>>   #define _BRK_THREADBP       11      /* For threads, user bp (used by 
>> debuggers) */
>> +#define BRK_BUG_MM   12      /* Used by BUG() in microMIPS mode */
>>   #define BRK_BUG             512     /* Used by BUG() */
>
> Can we move the CONFIG_CPU_MICROMIPS to here and just call the thing
> BRK_BUG?
>
No, because this header file is exported in 'arch/mips/include/uapi/asm' now. I 
already discussed this with Ralf.

>>   #include <asm/break.h>
>> +#ifdef CONFIG_CPU_MICROMIPS
>> +#undef BRK_BUG
>> +#define BRK_BUG              BRK_BUG_MM
>> +#endif
>>
>
> ...We don't need this bit.   Doing an #undef risks using different
> values for BRK_BUG depending on whether or not asm/bug.h is included.
>
I was trying to avoid two #ifdef's in 'bug.h' but I can certainly get rid of 
the above and use two #ifdef's instead.

-Steve

<Prev in Thread] Current Thread [Next in Thread>