linux-mips
[Top] [All Lists]

Re: [PATCH] mpis: cavium-octeon/executive/cvmx-l2c.c: fix uninitialized

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] mpis: cavium-octeon/executive/cvmx-l2c.c: fix uninitialized variable
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 16 Jan 2013 09:56:03 -0800
Cc: Cong Ding <dinggnu@gmail.com>, Jim Quinlan <jim2101024@gmail.com>, <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
In-reply-to: <20130116105757.GB26569@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358200025-15994-1-git-send-email-dinggnu@gmail.com> <20130116105757.GB26569@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 01/16/2013 02:57 AM, Ralf Baechle wrote:
On Mon, Jan 14, 2013 at 10:47:03PM +0100, Cong Ding wrote:

the variable dummy is used without initialization.

Interesting - I wonder how you found this one.  My compiler (gcc 4.7)
doesn't warn about this one.


I get no warnings either. So I wonder what the point of churning up the code is.

David Daney

Nor does gcc notice that the whole summing up business is wasted efford.

So here's my counter proposal.  It works because ptr is a volatile pointer
so the compiler will always dereference it even if the returned value is
not being used.  The resulting code is a bit smaller.

   Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

  arch/mips/cavium-octeon/executive/cvmx-l2c.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/executive/cvmx-l2c.c 
b/arch/mips/cavium-octeon/executive/cvmx-l2c.c
index 9f883bf..ec3e059 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-l2c.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-l2c.c
@@ -286,7 +286,7 @@ uint64_t cvmx_l2c_read_perf(uint32_t counter)
  static void fault_in(uint64_t addr, int len)
  {
        volatile char *ptr;
-       volatile char dummy;
+
        /*
         * Adjust addr and length so we get all cache lines even for
         * small ranges spanning two cache lines.
@@ -300,7 +300,7 @@ static void fault_in(uint64_t addr, int len)
         */
        CVMX_DCACHE_INVALIDATE;
        while (len > 0) {
-               dummy += *ptr;
+               *ptr;
                len -= CVMX_CACHE_LINE_SIZE;
                ptr += CVMX_CACHE_LINE_SIZE;
        }






<Prev in Thread] Current Thread [Next in Thread>