linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure
From: Thierry Reding <thierry.reding@avionic-design.de>
Date: Wed, 16 Jan 2013 10:51:14 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Arend van Spriel <arend@broadcom.com>
In-reply-to: <50F67719.5010005@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358321286-8695-1-git-send-email-thierry.reding@avionic-design.de> <50F67719.5010005@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 16, 2013 at 10:47:05AM +0100, Hauke Mehrtens wrote:
> On 01/16/2013 08:28 AM, Thierry Reding wrote:
> > Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
> > in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
> > however, so Kconfig complains about it:
> > 
> >     warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct 
> > dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> >     warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct 
> > dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> >     warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct 
> > dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> >     warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct 
> > dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> > 
> > This patch fixes the issue by explicitly selecting GPIOLIB if
> > BCM47XX_BCMA is enabled.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> 
> Arend van Spriel already send a similar patch fixing this issue, but it
> was not applied yet:
> https://patchwork.linux-mips.org/patch/4759/
> 
> CONFIG_GPIOLIB should also be selected by CONFIG_BCM47XX_SSB.

Okay, great. I wasn't aware of it, sorry for the noise.

Thierry

Attachment: pgp7BkKNFT6Ab.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>