linux-mips
[Top] [All Lists]

Re: [PATCH 04/10] MIPS: Netlogic: Split XLP L1 i-cache among threads

To: Jayachandran C <jchandra@broadcom.com>
Subject: Re: [PATCH 04/10] MIPS: Netlogic: Split XLP L1 i-cache among threads
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 15 Jan 2013 19:04:46 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1358179922-26663-5-git-send-email-jchandra@broadcom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1358179922-26663-1-git-send-email-jchandra@broadcom.com> <1358179922-26663-5-git-send-email-jchandra@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jan 14, 2013 at 09:41:56PM +0530, Jayachandran C wrote:

> Since we now use r4k cache code for Netlogic XLP, it is
> better to split L1 icache among the active threads, so that
> threads won't step on each other while flushing icache.
> 
> The L1 dcache is already split among the threads in the core.

It's a bit orthogonal to your patch but you may want to look at adding
support for SYS_SUPPORTS_SCHED_SMT which scheduler support for SMT that
is tries to schedule threads in a shared cache friendly way.  See
0ab7aefc4d43a6dee26c891b41ef9c7a67d2379b [[MIPS] MT: Scheduler support for
SMT].

  Ralf

<Prev in Thread] Current Thread [Next in Thread>