[Top] [All Lists]

Re: [PATCH] [RFC] Proposed changes to eliminate 'union mips_instruction'

To: "Steven J. Hill" <>
Subject: Re: [PATCH] [RFC] Proposed changes to eliminate 'union mips_instruction' type.
From: Ralf Baechle <>
Date: Tue, 15 Jan 2013 09:24:56 +0100
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 15, 2013 at 12:13:40AM -0600, Steven J. Hill wrote:

> From: "Steven J. Hill" <>
> This patch shows the use of macros in place of 'union mips_instruction'
> type. I converted all usages of 'j_format' and 'r_format' to show how
> the code and macros could look and be defined. I have tested these
> changes on big and little endian platforms.
> I want input from everyone, please!!! I want consensus on the macro
> definitions, placement of parenthesis for them, spacing in the header
> file, etc. This is your chance to be completely anal and have fun
> arguments over how things should be. I would also like input on how
> the maintainers would like the patchsets to look like. For example:
>   [1/X] - Convert 'j_format'
>   [2/X] - Convert 'r_format'
>   [3/X] - Convert 'f_format'
>   [4/X] - Convert 'u_format'
>   ...
>   [X/X] - Remove usage of 'union mips_instruction' type completely.
> Also, I noticed 'p_format' is not used anywhere. Can we kill it? Be
> picky and help with this conversion. Thanks.

Mayne not kill it completely abut leave a comment mentioning its existence
for the sake of completeness.


<Prev in Thread] Current Thread [Next in Thread>