linux-mips
[Top] [All Lists]

Re: 3.8-rc1 build failure with MIPS/SPARSEMEM

To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 14 Jan 2013 14:03:39 -0800
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=a0TlSNYfbB1r95RlGIlRUMYS4zVt3LagTgk+bXSBRpg=; b=yz7MMBJ/BejBph7urYy6qaJcicEjehQZHbQDeBL233vRHXXlURJ/e9xmceCtqPZJdv 7I6ngQnfQQoLV42HMvWGN2DBUmnhHA6vBy7FK2yGFpA++ZfYmdGgwGUYeET14f4NVuyM Qtk1Yu16tXzgqqw+gFDZGwEtivSQcMqPe1NDk6L0ZUHg62A/2dzob/ahm46lpCV/0ySe ngOisDS+VoWgZx6jLRJdXFHhCBbxEdeoWB/qYAQfARBB4MZEFOPPvRzUk0PTUQtmhY5r pyrepqIK92O0GEFdGPzI1nVTV9Pjp/tq7QteBwuvE4spP44MrlEN57+rbYcYshUakKe3 sSpg==
In-reply-to: <20130114151641.GA17996@otc-wbsnb-06>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <20121222122757.GB6847@blackmetal.musicnaut.iki.fi> <20121226003434.GA27760@otc-wbsnb-06> <20121227121607.GA7097@blackmetal.musicnaut.iki.fi> <20121230103850.GA5424@otc-wbsnb-06> <20130114151641.GA17996@otc-wbsnb-06>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 01/14/2013 07:16 AM, Kirill A. Shutemov wrote:
On Sun, Dec 30, 2012 at 12:38:50PM +0200, Kirill A. Shutemov wrote:
On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
Hi,

On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
On MIPS if SPARSEMEM is enabled we've got this:

In file included from 
/home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
                  from include/linux/mm.h:44,
                  from arch/mips/kernel/asm-offsets.c:14:
include/asm-generic/pgtable.h: In function ‘my_zero_pfn’:
include/asm-generic/pgtable.h:466: error: implicit declaration of function 
‘page_to_section’
In file included from arch/mips/kernel/asm-offsets.c:14:
include/linux/mm.h: At top level:
include/linux/mm.h:738: error: conflicting types for ‘page_to_section’
include/asm-generic/pgtable.h:466: note: previous implicit declaration of 
‘page_to_section’ was here

Due header files inter-dependencies, the only way I see to fix it is
convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>

Thanks, this works.

Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Andrew, could you take the patch?

I found the same problem and arrived at an equivalent solution.

Acked-by: David Daney <david.daney@cavium.com>


ping?



<Prev in Thread] Current Thread [Next in Thread>