linux-mips
[Top] [All Lists]

Re: 3.8-rc1 build failure with MIPS/SPARSEMEM

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: 3.8-rc1 build failure with MIPS/SPARSEMEM
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date: Mon, 14 Jan 2013 17:16:41 +0200
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@linux-mips.org, Aaro Koskinen <aaro.koskinen@iki.fi>
In-reply-to: <20121230103850.GA5424@otc-wbsnb-06>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <20121222122757.GB6847@blackmetal.musicnaut.iki.fi> <20121226003434.GA27760@otc-wbsnb-06> <20121227121607.GA7097@blackmetal.musicnaut.iki.fi> <20121230103850.GA5424@otc-wbsnb-06>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Dec 30, 2012 at 12:38:50PM +0200, Kirill A. Shutemov wrote:
> On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
> > Hi,
> > 
> > On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
> > > On MIPS if SPARSEMEM is enabled we've got this:
> > > 
> > > In file included from 
> > > /home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
> > >                  from include/linux/mm.h:44,
> > >                  from arch/mips/kernel/asm-offsets.c:14:
> > > include/asm-generic/pgtable.h: In function ‘my_zero_pfn’:
> > > include/asm-generic/pgtable.h:466: error: implicit declaration of 
> > > function ‘page_to_section’
> > > In file included from arch/mips/kernel/asm-offsets.c:14:
> > > include/linux/mm.h: At top level:
> > > include/linux/mm.h:738: error: conflicting types for ‘page_to_section’
> > > include/asm-generic/pgtable.h:466: note: previous implicit declaration of 
> > > ‘page_to_section’ was here
> > > 
> > > Due header files inter-dependencies, the only way I see to fix it is
> > > convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.
> > > 
> > > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > 
> > Thanks, this works.
> > 
> > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> 
> Andrew, could you take the patch?

ping?

-- 
 Kirill A. Shutemov

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>