linux-mips
[Top] [All Lists]

Re: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform

To: "Sergei Shtylyov" <sshtylyov@mvista.com>
Subject: Re: [PATCH] mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform
From: "Arend van Spriel" <arend@broadcom.com>
Date: Sun, 6 Jan 2013 22:13:56 +0100
Cc: "Ralf Baechle" <ralf@linux-mips.org>, linux-mips@linux-mips.org, "Hauke Mehrtens" <hauke@hauke-m.de>
In-reply-to: <50E80F78.9030901@mvista.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1357323005-28008-1-git-send-email-arend@broadcom.com> <50E80F78.9030901@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 01/05/2013 12:33 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 04-01-2013 22:10, Arend van Spriel wrote:
> 
>> The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected
>> respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These
>> options depend on GPIOLIB without explicitly selecting it
>> so it results in a warning when GPIOLIB is not set:
> 
>> scripts/kconfig/conf --oldconfig Kconfig
>> warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
>>     dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
>> warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct
>>     dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> 
>> which subsequently results in compile errors.
> 
>> Cc: Hauke Mehrtens <hauke@hauke-m.de>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>> ---
>> Fixing a Kconfig issue in our nightly Jenkins build.
> 
>> Gr. AvS
>> ---
>>   arch/mips/bcm47xx/Kconfig |    3 +++
>>   1 file changed, 3 insertions(+)
> 
>> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
>> index d7af29f..ba61192 100644
>> --- a/arch/mips/bcm47xx/Kconfig
>> +++ b/arch/mips/bcm47xx/Kconfig
>> @@ -8,8 +8,10 @@ config BCM47XX_SSB
>>       select SSB_DRIVER_EXTIF
>>       select SSB_EMBEDDED
>>       select SSB_B43_PCI_BRIDGE if PCI
>> +    select SSB_DRIVER_PCICORE if PCI
> 
>    This change doesn';t seem to be documented in your changelog. Maybe
> it's worth another patch?
> 
> WBR, Sergei
> 

Very observant. ;-) Yes. After fixing the other ones I got a warning on
that one. I could resubmit the change with a more generic description or
split it up as you suggest.

Ralf,

Please advice.

Gr. AvS



<Prev in Thread] Current Thread [Next in Thread>