| To: | linux-mips@linux-mips.org |
|---|---|
| Subject: | [PATCH v2]: Fix 3.7 mips build if !CONFIG_MODULES |
| From: | Joshua Kinard <kumba@gentoo.org> |
| Date: | Thu, 27 Dec 2012 14:46:46 -0500 |
| Cc: | Ralf Baechle <ralf@linux-mips.org> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1356637587; bh=G2ulGK3CR9sC5tSbUKBARlWtiizaxK9KaeH5r4+OUQ0=; h=Received:Received:Message-ID:Date:From:MIME-Version:To:Subject: Content-Type; b=XQrMZ9yvce/BPNGKOUIaYNLodCNYUTArGCeSJvGh/S/hn8Dtf+eyO9JcGI9tEVIXj +qstpKohXjasxX3L2tWJKE09nWFbAOyHyVGNHVmgimr/ukRmIZK5VKN8se2uPp1K1+ lEuQqKSuGU24czHE9wywnOUBDtC0pEEAG8IQpn6HcqGsN/Aw/MdT2sZb0BkYUfboyS shdB630F3UeH5s8mI5q2JFsp7VKuNOHHopVjFb6HFTEX0W3tSKRpUhTm6o1cDbdEjN uuWP0bnsbE0K40CC+q721kNtATciWSY3wdUgNZey4ItI5mek3Ad9tgTES4dtbNzToD FgbtcHVzGuIHw== |
| In-reply-to: | <50DC174D.6090302@gentoo.org> |
| List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
| List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
| List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
| List-owner: | <mailto:ralf@linux-mips.org> |
| List-post: | <mailto:linux-mips@linux-mips.org> |
| List-software: | Ecartis version 1.0.0 |
| List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
| List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
| References: | <50DC174D.6090302@gentoo.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
The attached patch fixes a build failure if building a monolithic kernel due
to arch/mips/kernel/Kconfig selecting MODULES_USE_ELF_REL[A] without
checking to see if MODULES is set or not. This leads to 'struct module' not
existing, which triggers a compile failure in arch/mips/kernel/module-rela.c
when the compiler attempts to dereference me->name on lines 36, 48, and 133.
Signed-off-by: Joshua Kinard <kumba@gentoo.org>
---
Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -Naurp a/arch/mips/Kconfig b/arch/mips/Kconfig
--- a/arch/mips/Kconfig 2012-12-22 22:52:28.264461836 -0500
+++ b/arch/mips/Kconfig 2012-12-26 23:00:46.202996691 -0500
@@ -39,8 +39,8 @@ config MIPS
select GENERIC_CLOCKEVENTS
select GENERIC_CMOS_UPDATE
select HAVE_MOD_ARCH_SPECIFIC
- select MODULES_USE_ELF_REL
- select MODULES_USE_ELF_RELA if 64BIT
+ select MODULES_USE_ELF_REL if MODULES
+ select MODULES_USE_ELF_RELA if MODULES && 64BIT
menu "Machine selection"
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH]: Fix 3.7 mips build if !CONFIG_MODULES, Joshua Kinard |
|---|---|
| Next by Date: | Re: [PATCH 0/6] MIPS: BCM47XX: nvram read enhancements, Rafał Miłecki |
| Previous by Thread: | Re: [PATCH]: Fix 3.7 mips build if !CONFIG_MODULES, Joshua Kinard |
| Next by Thread: | Unhandled kernel unaligned access on IP32 w/ network I/O && 3.7.1?, Joshua Kinard |
| Indexes: | [Date] [Thread] [Top] [All Lists] |