Re: [PATCH v2] MIPS: dsp: Add assembler support for DSP ASEs.

[Florian Fainelli <florian@openwrt.org>]

Le 12/16/12 12:42, Jonas Gorski a écrit :
> On 15 December 2012 06:06, Steven J. Hill <sjhill@mips.com> wrote:
> > (snip)
> > diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
> > index 33a96a9..c3c8cba 100644
> > --- a/arch/mips/kernel/Makefile
> > +++ b/arch/mips/kernel/Makefile
> > @@ -98,4 +98,31 @@ obj-$(CONFIG_HW_PERF_EVENTS) += perf_event_mipsxx.o
> >
> >   obj-$(CONFIG_JUMP_LABEL)       += jump_label.o
> >
> > +#
> > +# DSP ASE supported for MIPS32 or MIPS64 Release 2 cores only
> > +#
> > +ifeq ($(CONFIG_CPU_MIPSR2), y)
> > +CFLAGS_DSP                     = -DHAVE_AS_DSP
> 24K (non-E) is MIPS32r2, but not not implement any DSP ASEs, is this a
> problem here?
I do not think it is, all code-paths making use of the rddsp() wrdsp() 
macros are checking cpu_has_dsp() so we should be pretty safe here. It 
might be worth adding this comment to the Makefile though.
--
Florian