linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: dsp: Add assembler support for DSP ASEs.

To: Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH v2] MIPS: dsp: Add assembler support for DSP ASEs.
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 17 Dec 2012 10:46:51 +0100
Cc: "Steven J. Hill" <sjhill@mips.com>, linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4sDQm90M4KUZLH0sfmPHwP26kGvgPKATh8ItJ/Eep9g=; b=xDi7mrbfaPem6lQ0dMzyT1BCE+zOwrsLiGfUEVHe7jnWreh6tZpixnVMwaEN/N1xLC eapG0Y8buuzbLP3jzkPaEyydcYI1L8l0uL3U6ZKRtInIcldEMw4D4j2srVStUAoiAb2q zSAcOJGjC7zPj+ayOliVA0LJ6Bz8znv7eQMrNmvqiMKMnI4F+YL0pJfhTYtxwaK+f1vF GSYDPS3Lj0B2H/PRjPnif1kM7R37rjI0GHZwLHADrNKz88BDKqSAmby99PBb297KNP1i QGVZgBUXbg/nRGZ7NCLWJrtnLys9/V6hdiTTNN9MQdy7W3r3pCf79MOe5lqlyIsKUC0l 93Xg==
In-reply-to: <CAOiHx==V+owqPzFRgSYqz2VYtQoq8XevpJgfmwQLyxdLZ-52qQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1355547967-13779-1-git-send-email-sjhill@mips.com> <CAOiHx==V+owqPzFRgSYqz2VYtQoq8XevpJgfmwQLyxdLZ-52qQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
Le 12/16/12 12:42, Jonas Gorski a écrit :
On 15 December 2012 06:06, Steven J. Hill <sjhill@mips.com> wrote:
(snip)
diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
index 33a96a9..c3c8cba 100644
--- a/arch/mips/kernel/Makefile
+++ b/arch/mips/kernel/Makefile
@@ -98,4 +98,31 @@ obj-$(CONFIG_HW_PERF_EVENTS) += perf_event_mipsxx.o

  obj-$(CONFIG_JUMP_LABEL)       += jump_label.o

+#
+# DSP ASE supported for MIPS32 or MIPS64 Release 2 cores only
+#
+ifeq ($(CONFIG_CPU_MIPSR2), y)
+CFLAGS_DSP                     = -DHAVE_AS_DSP

24K (non-E) is MIPS32r2, but not not implement any DSP ASEs, is this a
problem here?

I do not think it is, all code-paths making use of the rddsp() wrdsp() macros are checking cpu_has_dsp() so we should be pretty safe here. It might be worth adding this comment to the Makefile though.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>