linux-mips
[Top] [All Lists]

Re: [PATCH] OF: MIPS: sead3: Implement OF support.

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] OF: MIPS: sead3: Implement OF support.
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 12 Dec 2012 15:56:44 +0100
Cc: "Steven J. Hill" <sjhill@mips.com>, linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=BrdTQJz6fgVJLsVXw4sLcITUwP+9RBYNq4X7KTnIur4=; b=vAu+cDGxfxs1zpNnIf3HxsnMhSqMWUNecTkVVsScTHvzNz6TPFFlCL8iATvd+TxV+C THz9NDoOfYTGDsnL+TTseIhSz9v0syv0qa0+tx7SDHGAZ164qzDxX9TSRtlxy8kEeSB0 hh1lMclEYuXLiq7Jlpl1qrddNhSVL9tvPrHfMsYnDLOeWNm3RfHneWCfBGa4/yCNNKDS 2qKPz5zKKjCUQRZs5xIz1bduOUz4UMQXSLJokWArw7P7vtY1qYMuyZs4zFbp03bJjGBj acDL3SLJLX1nC+p6d+CHdmJM4cG7CMMjorYiYYEqSsN1ZcCXJ1fXgFKL02kdytwQfbNd OGOw==
In-reply-to: <50C89A6C.705@metafoo.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1354857297-28863-1-git-send-email-sjhill@mips.com> <50C894D4.4090008@openwrt.org> <50C89A6C.705@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
Le 12/12/12 15:53, Lars-Peter Clausen a écrit :
On 12/12/2012 03:29 PM, Florian Fainelli wrote:
Hello Steven,

Le 12/07/12 06:14, Steven J. Hill a écrit :
[snip]

+/ {
+    #address-cells = <1>;
+    #size-cells = <1>;
+    compatible = "mips,sead-3";
+
+    cpus {
+        cpu@0 {
+            compatible = "mips,mips14Kc,mips14KEc";
+        };
You probably want this the other way around:

mips14KEc,mips14Kc,mips

you should always have the left-most string being the most descriptive about
the hardware and the last one being the less descriptive and thus less
"specializing" in order to be backward compatible.
This is one compatible string though, what you describe is for when use
multiple compatible string. E.g.
compatible = "mips14KEc", "mips14Kc", "mips";

The "mips" in Stevens patch is probably the vendor prefix. Maybe a more
correct compatible would be.

compatible = "mips,mips14KEc", "mips,mips14Kc";

Right, this should be the proper compatible string. Steven's patch does not make any use of this compatible string right now anyway.


But in anyway the patch should also add documentation under
Documentation/devicetree/bindings describing the binding.

Obviously
--
Florian

<Prev in Thread] Current Thread [Next in Thread>