linux-mips
[Top] [All Lists]

Re: [PATCH] OF: MIPS: sead3: Implement OF support.

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] OF: MIPS: sead3: Implement OF support.
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Wed, 12 Dec 2012 15:53:32 +0100
Cc: "Steven J. Hill" <sjhill@mips.com>, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <50C894D4.4090008@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1354857297-28863-1-git-send-email-sjhill@mips.com> <50C894D4.4090008@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121027 Icedove/10.0.10
On 12/12/2012 03:29 PM, Florian Fainelli wrote:
> Hello Steven,
> 
> Le 12/07/12 06:14, Steven J. Hill a écrit :
> [snip]
> 
>> +/ {
>> +    #address-cells = <1>;
>> +    #size-cells = <1>;
>> +    compatible = "mips,sead-3";
>> +
>> +    cpus {
>> +        cpu@0 {
>> +            compatible = "mips,mips14Kc,mips14KEc";
>> +        };
> 
> You probably want this the other way around:
> 
> mips14KEc,mips14Kc,mips
> 
> you should always have the left-most string being the most descriptive about
> the hardware and the last one being the less descriptive and thus less
> "specializing" in order to be backward compatible.

This is one compatible string though, what you describe is for when use
multiple compatible string. E.g.
compatible = "mips14KEc", "mips14Kc", "mips";

The "mips" in Stevens patch is probably the vendor prefix. Maybe a more
correct compatible would be.

compatible = "mips,mips14KEc", "mips,mips14Kc";

But in anyway the patch should also add documentation under
Documentation/devicetree/bindings describing the binding.

> 
>> +    };
>> +
>> +    chosen {
>> +        bootargs = "console=ttyS1,38400 rootdelay=10 root=/dev/sda3";
>> +    };
>> +
>> +    memory {
>> +        device_type = "memory";
>> +        reg = <0x0 0x08000000>;
>> +    };
>> +};
>>
> 


<Prev in Thread] Current Thread [Next in Thread>