linux-mips
[Top] [All Lists]

Re: [PATCH] OF: MIPS: sead3: Implement OF support.

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH] OF: MIPS: sead3: Implement OF support.
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 12 Dec 2012 15:29:40 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=L2ALDhU5foDbrLvL5LCUIbcMqDf5lZAe2Fk2Ul1YaeA=; b=S/PKhJYJNwFRTRYadm/ajD8QRySJJT3yU+ECi47XRMCXOKRuS6mkVVJfKhOUxXjXY+ wrjFeoh/Nr96pNCv4YeXv9Lf8otuoOXJ2DZOfpuNykjCPPCCuh5zKbi8UwuMXjbuIvue jeuYaj6kA70P/hdm3i0JH/VXf1yMAPOlJGSwPk4mLcM+9BnZP6KJqS3pKLFGku6CYvrF I4o/Z+I4rk1WTcedkc73PwOnQWDtHfYUjFaqBZd7B5dFGNi72dJoReo/AykftF4UxYRQ aDk2srF7tWqvhH492+FfVRSCcm34iOcdi/9W+R5FreLAeKcCx+LqOW9ThikrwYUr1BXk C7xA==
In-reply-to: <1354857297-28863-1-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1354857297-28863-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
Hello Steven,

Le 12/07/12 06:14, Steven J. Hill a écrit :
[snip]

+/ {
+       #address-cells = <1>;
+       #size-cells = <1>;
+       compatible = "mips,sead-3";
+
+       cpus {
+               cpu@0 {
+                       compatible = "mips,mips14Kc,mips14KEc";
+               };

You probably want this the other way around:

mips14KEc,mips14Kc,mips

you should always have the left-most string being the most descriptive about the hardware and the last one being the less descriptive and thus less "specializing" in order to be backward compatible.

+       };
+
+       chosen {
+               bootargs = "console=ttyS1,38400 rootdelay=10 root=/dev/sda3";
+       };
+
+       memory {
+               device_type = "memory";
+               reg = <0x0 0x08000000>;
+       };
+};


<Prev in Thread] Current Thread [Next in Thread>