| To: | Ralf Baechle <ralf@linux-mips.org>, David Daney <david.daney@cavium.com> |
|---|---|
| Subject: | [PATCH] MIPS: Check BITS_PER_LONG instead of __SIZEOF_LONG__ |
| From: | Geert Uytterhoeven <geert@linux-m68k.org> |
| Date: | Thu, 6 Dec 2012 20:12:17 +0100 |
| Cc: | linux-mips@linux-mips.org, Geert Uytterhoeven <geert@linux-m68k.org> |
| List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
| List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
| List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
| List-owner: | <mailto:ralf@linux-mips.org> |
| List-post: | <mailto:linux-mips@linux-mips.org> |
| List-software: | Ecartis version 1.0.0 |
| List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
| List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
| Sender: | linux-mips-bounce@linux-mips.org |
When building a 32-bit kernel for RBTX4927 with gcc version 4.1.2 20061115
(prerelease) (Ubuntu 4.1.1-21), I get:
arch/mips/lib/delay.c:24:5: warning: "__SIZEOF_LONG__" is not defined
As a consequence, __delay() always uses the 64-bit "dsubu" instruction.
Replace the check for "__SIZEOF_LONG__ == 4" by "BITS_PER_LONG == 32" to
fix this.
Introduced by commit 5210edcd527773c227465ad18e416a894966324f ("MIPS: Make
__{,n,u}delay declarations match definitions and generic delay.h")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--
Untested on real hardware.
Ralf, is this sufficient to prevent you from nuking RBTX4927 support? ;-)
---
arch/mips/lib/delay.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
index dc81ca8..288f795 100644
--- a/arch/mips/lib/delay.c
+++ b/arch/mips/lib/delay.c
@@ -21,7 +21,7 @@ void __delay(unsigned long loops)
" .set noreorder \n"
" .align 3 \n"
"1: bnez %0, 1b \n"
-#if __SIZEOF_LONG__ == 4
+#if BITS_PER_LONG == 32
" subu %0, 1 \n"
#else
" dsubu %0, 1 \n"
--
1.7.0.4
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RM9000 / E9000, MSP71xx class processors, SOCs and eval boards, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] MIPS: Check BITS_PER_LONG instead of __SIZEOF_LONG__, David Daney |
| Previous by Thread: | RM9000 / E9000, MSP71xx class processors, SOCs and eval boards, Ralf Baechle |
| Next by Thread: | Re: [PATCH] MIPS: Check BITS_PER_LONG instead of __SIZEOF_LONG__, David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |