linux-mips
[Top] [All Lists]

Re: [PATCH 05/15] MIPS: Netlogic: keep .dtb/.dtb.S until make clean

To: Jayachandran C <jchandra@broadcom.com>
Subject: Re: [PATCH 05/15] MIPS: Netlogic: keep .dtb/.dtb.S until make clean
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 28 Nov 2012 13:22:55 +0100
Cc: linux-mips@linux-mips.org, Michal Marek <mmarek@suse.cz>, Grant Likely <grant.likely@secretlab.ca>, Rob Herring <rob.herring@calxeda.com>, John Crispin <blogic@openwrt.org>
In-reply-to: <7a800eb7eb2a75800749cab24e67c6b1e3c76b7c.1351688140.git.jchandra@broadcom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <cover.1351688140.git.jchandra@broadcom.com> <7a800eb7eb2a75800749cab24e67c6b1e3c76b7c.1351688140.git.jchandra@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 31, 2012 at 06:31:31PM +0530, Jayachandran C wrote:

> Provide a .SECONDARY entry for these intermediate files. Otherwise
> make deletes them, and these files are regenerated for every rebuild.
> 
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
>  arch/mips/netlogic/dts/Makefile |   16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/netlogic/dts/Makefile b/arch/mips/netlogic/dts/Makefile
> index 67ae3fe2..40502ff 100644
> --- a/arch/mips/netlogic/dts/Makefile
> +++ b/arch/mips/netlogic/dts/Makefile
> @@ -1,4 +1,14 @@
> -obj-$(CONFIG_DT_XLP_EVP) := xlp_evp.dtb.o
> +DTS_FILE             = xlp_evp.dts
> +DTB_FILE             = $(patsubst %.dts, %.dtb, $(DTS_FILE))
>  
> -$(obj)/%.dtb: $(obj)/%.dts
> -     $(call if_changed,dtc)
> +# built-in dtb
> +obj-$(CONFIG_DT_XLP_EVP) := $(DTB_FILE).o
> +
> +$(obj)/%.dtb: $(src)/%.dts
> +     $(call if_changed_dep,dtc)
> +
> +# Keep intermediate files .dtb and .dtb.S, delete them only at make clean
> +KEEP_FILES           = $(DTB_FILE) $(DTB_FILE).S
> +clean-files          += $(KEEP_FILES)
> +
> +.SECONDARY: $(addprefix $(obj)/, $(KEEP_FILES))

This patch conflicts with a patch series by Stephen Warren to centralize
the .dts -> .dtb rules that currently exist scattered across arch/.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 05/15] MIPS: Netlogic: keep .dtb/.dtb.S until make clean, Ralf Baechle <=