On 11/20/2012 09:12 AM, John Crispin wrote:
> Hi Hauke,
>
>
>> +#ifdef CONFIG_SSB_DRIVER_EXTIF
>
> ...
>
>> +}
>> +
>> +#else
>> +static int ssb_gpio_extif_init(struct ssb_bus *bus)
>> +{
>> + return 0;
>> +}
>> +#endif
>
> ssb_gpio_extif_init() is also defined as a static inline stub in the
> header files. you should drop this definition from the code file
>
> John
No, ssb_gpio_extif_init() is only defined in drivers/ssb/driver_gpio.c
and not ssb_private.h, ssb_gpio_init() is defined in ssb_private.h.
Hauke
|