linux-mips
[Top] [All Lists]

Re: [PATCH 7/8] ssb: add GPIO driver

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH 7/8] ssb: add GPIO driver
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Tue, 20 Nov 2012 22:07:42 +0100
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-wireless@vger.kernel.org, florian@openwrt.org, zajec5@gmail.com, m@bues.ch
In-reply-to: <50AB3B6C.4000505@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1353365877-11131-1-git-send-email-hauke@hauke-m.de> <1353365877-11131-8-git-send-email-hauke@hauke-m.de> <50AB3B6C.4000505@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
On 11/20/2012 09:12 AM, John Crispin wrote:
> Hi Hauke,
> 
> 
>> +#ifdef CONFIG_SSB_DRIVER_EXTIF
> 
> ...
> 
>> +}
>> +
>> +#else
>> +static int ssb_gpio_extif_init(struct ssb_bus *bus)
>> +{
>> +    return 0;
>> +}
>> +#endif
> 
> ssb_gpio_extif_init() is also defined as a static inline stub in the
> header files. you should drop this definition from the code file
> 
>     John
No, ssb_gpio_extif_init() is only defined in drivers/ssb/driver_gpio.c
and not ssb_private.h, ssb_gpio_init() is defined in ssb_private.h.

Hauke

<Prev in Thread] Current Thread [Next in Thread>